00-Evan / shattered-pixel-dungeon

Shattered Pixel Dungeon is an open-source traditional roguelike dungeon crawler with randomized levels and enemies, and hundreds of items to collect and use. It's based on the source code of Pixel Dungeon, by Watabou.
https://shatteredpixel.com/shatteredpd/
GNU General Public License v3.0
4.77k stars 1.12k forks source link

using chalice doesn't build rage #1038

Closed protective1 closed 2 years ago

protective1 commented 2 years ago

Berserker builds rage from physical damage. Pricking finger on chalice does not build rage. Do you consider damage from chalice to be purely magical?

protective1 commented 2 years ago

Related to this, chalice damage is reduced by armor, but my understanding is that armor doesn't block magical damage. That seems to imply that chalice damage is physical, not magical.

Block-Vader commented 2 years ago

It's a bit wonky. Chalice prick is considered physical damage, but not an attack. Armor does apply, other on hit effects (like rage buildup or glyphs) do not, since these effects require you to be attacked by something.

00-Evan commented 2 years ago

This is correct, using the chalice does not count as being attacked. Unlike most other sources of neutral damage, armor does apply though.

protective1 commented 2 years ago

@00-Evan - It sounds like the description for berserker needs tweaking. The text says, "As the berserker takes physical damage, his rage will build." It says nothing about the physical damage needing to be an attack.

00-Evan commented 2 years ago

The chalice is not physical damage, it is a special type of magic damage that has different effects apply than normal.