search

003random / getJS

A tool to fastly get all javascript sources/files
MIT License
731 stars 103 forks source link

Timeout Issue #2

Closed jaikishantulswani closed 6 years ago

jaikishantulswani commented 6 years ago

Hello @003random , getting i/o timeout issue if the first resource is not resolving from list of domains.

003random commented 6 years ago

Hey @jaikishantulswani. Please include a screenshot and the command you used (the options/arguments passed to it), so I can see where the problem comes from :)

jaikishantulswani commented 6 years ago

abcd xyz

003random commented 6 years ago

ah. So the first url in the domains.txt is not resolvable?

003random commented 6 years ago

https://github.com/003random/getJS/blob/master/main.go#L159 I added a ToDo for myself, and will edit it :)

003random commented 6 years ago

thanks for letting me know!

003random commented 6 years ago

The problem seems a bit bigger. I am working on it now. I will keep you updated!

003random commented 6 years ago

Alright. So I worked it out. Now it only trows a warning saying that it didnt return a 200, or that it timed out. The program doesn't exit anymore. The errors are outputted to stderr. If you dont want the errors to be displayed, you can append 2> /dev/null to write them to dev/null

003random commented 6 years ago

Just merged the commit. Thanks for bringing this up to me! Can you please confirm if it works as intended now?

jaikishantulswani commented 6 years ago

Hey @003random Its working !!! Thank you for resolving this issue so quickly. One more thing if you add switch to fetch all resources or filter resources like if we like to find storage bucket links i.e amazonaws, digitalocean, googleapi storage then it would become a one to go tool for all the things.

Thank you !

003random commented 6 years ago

Hey @jaikishantulswani. Nice idea! Unfortunately that is not something for in this tool. I will keep it in the back of my head as a new tool idea :) Closing this now, since it it resolved.