Closed mceachen closed 1 year ago
(I found this project via https://www.mklibrary.com/synology-nvme-volume/)
That's a well written guide. I might put a link to it on my readme page.
I do use shellcheck.
args="$@"
is just so I can echo the arguments used. But I could change it args=("$@")
ICYMI, you can prepend the line # shellcheck disable=SC2015
(or whatever the warning is) right above the offending line of code if you've checked out the linting error and have determined it's a false positive or otherwise ignorable. Docs are here.
Thanks again.
Thanks for this work!
In case you've not seen it before, shellcheck is a great linter for shell, and integrates with a bunch of editors (I use the this extension with vscode, fwiw).
It didn't find anything horrible here--just a few nits:
Feel free to close this issue--I just wanted to stop by and thank you for your work.
(I found this project via https://www.mklibrary.com/synology-nvme-volume/)
Cheers!