search

007revad / Synology_M2_volume

Easily create an M.2 volume on Synology NAS
MIT License
810 stars 56 forks source link

Update syno_create_m2_volume.sh - fixed a typo #85

Closed vaishraj closed 11 months ago

vaishraj commented 11 months ago

fixed an error echo statement

007revad commented 11 months ago

Nice work.

Were the spaces at the end of some lines my typos or yours?

I like the maxdisk=25 It make me want to do an Xpenology build. Is there a reason you chose 25 and not 32?

Was the echo "dum" on line 686 left over from debugging?

vaishraj commented 11 months ago

Thank you.

Not sure about the spaces, might have been my typos.

maxdisk - that's a good call. I wanted to set it very high. 32 makes better sense than my arbitrary 25 limit.

That echo is a good catch - it was my debug when something didn't work but I forgot to remove it.

-Raj

On Fri, Sep 8, 2023 at 6:01 PM Dave Russell @.***> wrote:

Nice work.

Were the spaces at the end of some lines my typos or yours?

I like the maxdisk=25 It make me want to do an Xpenology build. Is there a reason you chose 25 and not 32?

Was the echo "dum" on line 686 left over from debugging?

— Reply to this email directly, view it on GitHub https://github.com/007revad/Synology_M2_volume/pull/85#issuecomment-1712368877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE5CN4DAY7HNVZH5HZD5JDXZO5XZANCNFSM6AAAAAA4Q6YHLY . You are receiving this because you authored the thread.Message ID: @.***>

007revad commented 11 months ago

For some reason GitHub isn't showing you as a contributor. That may because I haven't pushed the changes to the main branch yet.

I've done a comparison and the spaces were my typos.

I've made some small changes that shellcheck complained about (some of it was mine and some yours). I've also merged some changes I had on my computer but hadn't pulled to github yet. I want to test the script before I do a pull... but my test Synology is currently busy and it's NVMe drives are currently sitting on my desk.

vaishraj commented 11 months ago

Thanks for the update, Dave.

Keep the great work. I am glad to contribute in a small way,

Raj

On Fri, Sep 8, 2023 at 10:48 PM Dave Russell @.***> wrote:

For some reason GitHub isn't showing you as a contributor. That may because I haven't pushed the changes to the main branch yet.

I've done a comparison and the spaces were my typos.

I've made some small changes that shellcheck complained about (some of it was mine and some yours). I've also merged some changes I had on my computer but hadn't pulled to github yet. I want to test the script before I do a pull... but my test Synology is currently busy and it's NVMe drives are currently sitting on my desk.

— Reply to this email directly, view it on GitHub https://github.com/007revad/Synology_M2_volume/pull/85#issuecomment-1712424813, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE5CNYTOB3FA5QGX35MYQTXZP7KPANCNFSM6AAAAAA4Q6YHLY . You are receiving this because you authored the thread.Message ID: @.***>