007revad / Synology_enable_Deduplication

Enable deduplication with non-Synology SSDs and unsupported NAS models
MIT License
70 stars 4 forks source link

M.2 warning displays escape code instead of using yellow color #46

Closed herbingk closed 6 months ago

herbingk commented 6 months ago

M.2 warning displays escape code instead of using yellow color. Occurs with the Synology_HDD_db script as well.

Seems like the -e param is missing from the echo statement:

echo "${Yellow}WARNING${Off} Don't store this script on an NVMe volume!"

Sample output:

Synology_enable_Deduplication v1.2.15 DS1621+ DSM 7.2.1-69057-3 StorageManager 1.0.0-0017

Using options: -c Running from: /volume1/admin/Synology_Enable_Dedupe/syno_enable_dedupe.sh \e[0;33mWARNING\e[0m Don't store this script on an NVMe volume!

Thanks for loooking into it.

007revad commented 6 months ago

Thanks.

I just checked and 5 of my scripts are missing the -e for that warning!

007revad commented 6 months ago

Fixed in https://github.com/007revad/Synology_enable_Deduplication/releases/tag/v1.2.17

Thank you.