007revad / Synology_enable_M2_volume

Enable creating volumes with non-Synology M.2 drives
MIT License
501 stars 36 forks source link

about bc dependent #114

Closed wjz304 closed 1 year ago

wjz304 commented 1 year ago

https://github.com/007revad/Synology_enable_M2_volume/blob/96ecdb5225d2bfd9b9bec6284c796c138ed18920/syno_enable_m2_volume.sh#L157 If not have, would be better to directly download it? curl -kL https://raw.githubusercontent.com/007revad/Synology_enable_M2_volume/main/bin/bc -o /tmp/bc

wjz304 commented 1 year ago

https://github.com/007revad/Synology_enable_M2_volume/blob/96ecdb5225d2bfd9b9bec6284c796c138ed18920/syno_enable_m2_volume.sh#L392

Can we add a parameter to skip interaction?

007revad commented 1 year ago

If not have, would be better to directly download it? curl -kL https://raw.githubusercontent.com/007revad/Synology_enable_M2_volume/main/bin/bc -o /tmp/bc

Yes. I added /bin/bc recently so I could have the script download it but hadn't got around to editing the script yet.

007revad commented 1 year ago

Can we add a parameter to skip interaction?

Do you want to:

  1. Skip interaction and have the script reboot the machine?
  2. Or skip the rebootmsg function?
wjz304 commented 1 year ago

Can we add a parameter to skip interaction?

Do you want to:

  1. Skip interaction and have the script reboot the machine?
  2. Or skip the rebootmsg function?

I want both 7@VLUAPVWIOIU}7S ZJ$VNF

007revad commented 1 year ago

Can we add a parameter to skip interaction?

Do you want to:

  1. Skip interaction and have the script reboot the machine?
  2. Or skip the rebootmsg function?

I want both

You want to skip interaction and reboot the machine while not rebooting the machine? :)

Or do you want 2 parameters so you have choice to either:

wjz304 commented 1 year ago

Can we add a parameter to skip interaction?

Do you want to:

  1. Skip interaction and have the script reboot the machine?
  2. Or skip the rebootmsg function?

I want both

You want to skip interaction and reboot the machine while not rebooting the machine? :)

Or do you want 2 parameters so you have choice to either:

  • Reboot without interaction.
  • No interaction and no reboot.

No interaction and no reboot.

The main issue is that there is no way to interact in addons (services), so skipping interaction is a priority. As for restarting, from the user's subjective perspective, automatic restarting may not be good. So I think skipping the reboot should be good.

(Sorry, my English is very poor. I'm not sure if I can express myself clearly)

007revad commented 1 year ago

Your English is good.

I've updated the script. https://github.com/007revad/Synology_enable_M2_volume/releases/tag/v1.0.10

wjz304 commented 1 year ago

Thx!, 33ZP(L0_BU5T9%IEMWO_`OE