search

01-edu / Branch-Mobile

🎯 Repository for the Mobile branch Dart tests.
1 stars 1 forks source link

Audits do not sufficiently evaluate the projects #13

Closed davhojt closed 2 years ago

davhojt commented 2 years ago

The steps in the audits are not thorough enough to evaluate the projects.

For example, we do not test "log out" here. What if you create two accounts. Can you only see data for the currently authenticated user? https://github.com/01-edu/Branch-Mobile/blob/b96e0ece04b0749431f48909eea19dfd523caf59/subjects/projects/stockMarket/audit/README.md?plain=1#L5

Some audit questions are general purpose, and are not specific to the project. For example, we should do something like:

##### Ask the student to show their provider implementation

###### Has the student implemented a provider pattern?

Instead, there are general questions: https://github.com/01-edu/Branch-Mobile/blob/b96e0ece04b0749431f48909eea19dfd523caf59/subjects/projects/stockMarket/audit/README.md?plain=1#L13 https://github.com/01-edu/Branch-Mobile/blob/b96e0ece04b0749431f48909eea19dfd523caf59/subjects/projects/skyMap/audit/README.md?plain=1#L15