search

010PHP / 010php.nl

[DEPRECATED] The 010PHP Website
0 stars 1 forks source link

Get Tweets from 010php account specifically #45

Closed oldskool closed 8 years ago

oldskool commented 8 years ago

The Twitter service currently gets the tweets for the account to which the tokens set in the parameters.yml file belong. So, if you create tokens on your personal account, it will show your personal tweets on the homepage. This fix makes sure the tweets from the @010php account are fetched, regardless of who owns the tokens.

For documentation on the added parameter, see https://dev.twitter.com/rest/reference/get/statuses/user_timeline

reenl commented 8 years ago

Yay we got another contributer! Nice job!

oldskool commented 8 years ago

@reenl Thanks for your input. I originally had it setup like this: https://github.com/010PHP/010php.nl/pull/45/commits/a52d08381b32497d0009e9d09dce428df8898cca

But I figured that's not as dynamic as setting it through the parameters. But I figure the screen name won't change anytime (soon), so we might as well use that constant instead. I can just rebase the PR to exclude the second commit.

reenl commented 8 years ago

@oldskool I get where you are comming from. Lets wait what caroga has to say. For me the last commit is easy to add, but hard to remove, so that is why I would like to postpone it as long as possible.

oldskool commented 8 years ago

Closing this in favor of #47