search

01alchemist / TurboScript

Super charged typed JavaScript dialect for parallel programming which compiles to WebAssembly
Apache License 2.0
493 stars 35 forks source link

Bugfix calling self methods in generic class issue#69 #73

Closed nidin closed 7 years ago

nidin commented 7 years ago

WebAssembly and ASM.JS self member access in generic class issue fixed. added getAsmjsInstance utils added. Closes #69

nidin commented 7 years ago

That's exactly my plan, add more jest tests to cover mvp features and release initial version. I was doing the golden files check manually. Of course we can continue it using jest. I will configure it soon. Thanks for your input.

On Sun 7. May 2017 at 4:41 PM, Wink Saville notifications@github.com wrote:

@winksaville approved this pull request.

LGTM, my one comment would be to add jest tests now rather than later as I think they are more thorough. One other thing, I've got a change being reviewed for binaryen wasm-merge. And it looks like there testing scheme relies on comparing the generated code with "gloden" files instead of executing. I've also seen this on gcc. I think they do this because they often don't have the execution environment.

Personally, I think execution is "better" but I suspect comparing the generated code against golden files will find a different set of bugs than execution, so I think you should consider using both styles. Of course, maybe you're already doing that. In any case YMMV :)

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/01alchemist/TurboScript/pull/73#pullrequestreview-36666102, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMGZiRI7emINTphlQ6ZRwUmK6plK8sAks5r3dgSgaJpZM4NTDvq .