search

050644zf / ArknightsStoryTextReader

A website that help you read Arknights Stories
https://astr.pages.dev
MIT License
332 stars 20 forks source link

Progressive web app support #66

Open RieLCho opened 1 month ago

RieLCho commented 1 month ago

I like your website, so I want to install as PWA application in my phone.

Any thoughts of supporting PWA installation? https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps

If so, I can do a research and make a pull request. (kinda busy by mid-term test and company work though, might be slow)

050644zf commented 1 month ago

PWA would be a good idea. However, ASTR is originally an amateur project for studying propose, it's now suffering from poor coding and bad arch. Rather than continue the current site, i would like to migrate to new framework and rewrite the whole site as mentioned in #34 . So i won't recommend applying major changes on the current site.

RieLCho commented 1 month ago

Is there new framework branch or repo working on?

050644zf commented 1 month ago

Is there new framework branch or repo working on?

I haven't start working on it so far. Personally i think i will use vuetify.

RieLCho commented 1 month ago

I guess pwa feature is independent from code base (as far as i asked to gpt4 😇). So after you migrate to vuetify and rebuild architectures, pwa could be applied same to new migrated project.

I will personally study pwa and make a new PR when it is possible to apply & released.

Thank you🙏

050644zf commented 1 month ago

btw there is some issue (#67 ) about the header which may harm the experience of PWA. Would be appreciated if u can fixed that.

RieLCho commented 1 month ago

Oh, Okay. I happen to looking at header.vue file btw. Just wondering why the css messed up with firefox.