Closed craigraw closed 1 year ago
This is related to kmp-tor
, yah?
I really do not want to break the current API and hope there is a solution via a deprecation cycle.
If I were to:
...encoding.base16.Builders.kt
)encoding.builders
package
1.2.3
kmp-tor
to use the new Builders.kt
package pathWould you be able to update your module config in Sparrow Wallet
to no longer export the ...builders
path, and only export the ...builders.base*
packages?
Deprecation cycle did not work. JPMS is still throwing exception even when no references are had to the .builders
package. Will need to remove the .builders
packages from base16
, base32
, and base64
modules.
POA:
1.2.3
with deprecation notices and a way for library consumers to gracefully update to new builder functions package locations.2.0.0
with API breaking changes (...encoding.builders
package removed).CHANGELOG
and release notes.
The package
io.matthewnelson.encoding.builders
is split across 3 jars. When using Java modules, these jars become modules, and this results in a split package which is disallowed by JPMS. This results in errors at runtime for example:Package io.matthewnelson.encoding.builders in both module encoding.base16.jvm and module encoding.base32.jvm
.There are two solutions - either package the
encoding-base*-jvm
jars as one jar, or change the package name in each of the jars, for example:io.matthewnelson.encoding.builders16
,io.matthewnelson.encoding.builders32
,io.matthewnelson.encoding.builders64
.