Implement `Base32` decoding for new `EncoderDecoder`

05nelsonm / encoding

A Kotlin Multiplatform library for configurable, streamable, efficient and extensible Encoding/Decoding with support for base16/32/64.

Apache License 2.0

33 stars 5 forks source link

Implement `Base32` decoding for new `EncoderDecoder` #55

Closed 05nelsonm closed 1 year ago

05nelsonm commented 1 year ago

Part 2 of #41

This PR:

Implements the decoding for all 3 spec's (Crockford, RFC 4648 section 6, RFC 4648 section 7) using the new EncoderDecoder
Maps the old decoding extension function bodies to use the new EncoderDecoder for Base32.
Creates a new class for commonizing bit buffers (so it can be reusable in higher level modules, such as Base32).
Fixed a bug in Decoder extension functions where padding was being sent unnecessarily.

05nelsonm commented 1 year ago

I think though there can be more things shifted to encoding-core, like skipping over new lines/spaces, or handling padding. Those 2 things are expressed in the base configuration and should be used to mitigate duplicate, unnecessary code.

Resolved in commit 52f426b :muscle: