`EncoderDecoder.Config.toStringAddSettings` implementation should add lines before/after

05nelsonm / encoding

A Kotlin Multiplatform library for configurable, streamable, efficient and extensible Encoding/Decoding with support for base16/32/64.

Apache License 2.0

33 stars 5 forks source link

`EncoderDecoder.Config.toStringAddSettings` implementation should add lines before/after #81

Closed 05nelsonm closed 1 year ago

05nelsonm commented 1 year ago

The implementation of EncoderDecoder.Config should call appendLine before and after adding it's custom settings to the output, not EncoderDecoder.Config.toString. The current implementation could result in 2 empty lines in the output if the implementation does not have any settings to add.

05nelsonm commented 1 year ago

Alternatively, toStringAddSettings should return Set<Pair<String, Any?>>...