`EncoderDecoder.Config.Setting` should only take into consideration `name` for `equals`/`hashCode`

05nelsonm / encoding

A Kotlin Multiplatform library for configurable, streamable, efficient and extensible Encoding/Decoding with support for base16/32/64.

Apache License 2.0

33 stars 5 forks source link

`EncoderDecoder.Config.Setting` should only take into consideration `name` for `equals`/`hashCode` #87

Closed 05nelsonm closed 1 year ago

05nelsonm commented 1 year ago

Currently, Setting class computes the equals and hashCode by including the value. This is incorrect as it should only consider the name property. The way it is now, the Set<Setting> returned by toStringAddSettings could contain multiple settings with the same name.