07th-mod / higurashi-assembly

9 stars 8 forks source link

Mod Features and Save Files #13

Open ghost opened 5 years ago

ghost commented 5 years ago

cc @tellowkrinkle cc @orian34 in case you have found any related issues.

A number of modded features were designed without individual game save files in mind. For example, I created a little mod for myself recently to play back the most recent voice, storing it in memory, but after a quick load the last voice isn't remembered. We had to add state for lip sync and sprite switching etc. but I don't believe any of it is persisted besides the flags, so there may be unexpected behavior when someone boots up the game again and loads a save file in the middle of a scene. I have a feeling this is related to the issue of people seeing double sprites. Let's investigate this.

(Btw, global flags are persisted automatically without respect to save files, so that's separate.)

orian34 commented 5 years ago

From discord: Seems like the save system already uses a voice replay feature. I feel like someone was lazy and just copy pasted the save function of the engine for the in-between menu. Playing a voice line just before saving the game or accessing the menu, then reloading the save or entering the same menu will cause the voice replay.

The save file also replays the last text line and the current BGMs. I will test more on saves later.