search

07th-mod / higurashi-assembly

9 stars 8 forks source link

Rotated sprites don't render properly when using 4:3 backgrounds / sprite cropping #72

Closed drojf closed 2 years ago

drojf commented 2 years ago

In that scene where Rena is at an angle, the sprite is cut off, no matter the sprite option, no matter the text appearance option, if the 4:3/Original BG is used. image image

_Originally posted by @cam1170 in https://github.com/07th-mod/higurashi-assembly/issues/133

drojf commented 2 years ago

I wasn't sure of the status of this - checking my computer I did make a fix for this but on a different branch.

I wrote the following for the commit:

Disable character rotation in 4:3 mode to avoid artifacting (#72)

  • Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
  • As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
  • This should only affect images from the sprite or portrait folder

The "fix" just disables rotation in OG mode: https://github.com/07th-mod/higurashi-assembly/commit/2361dafe08f8217949ccbccf3599de0bc4a8c32d

I'm not sure why I didn't merge it into the mod.

drojf commented 2 years ago

This should now be fixed in all chapters except console arcs (there is no OG mode for console arcs anyway)