Closed DoctorDiablo closed 6 years ago
I already made all the Sprites with the 1440p resolution including the weather variations but it seems that the 1440p is giving problems to lipsync so I don't know if we should use them.
Gotcha. Well, I guess we should let the rest of the team figure out lipsync and just go along with whatever they decide.
Let me ping @P-Chang here to get some info about the issue with lip-sync and 1440p.
Basically, new way could handle 1440p one. but 1080p one have more better performance. 1440p one had terrible performance because game was designed as every time load sprites from drive.
New way store 3 sprites in VRAM with lipsync. But I didn't concern 0.5GB or 1GB VRAM user.
old 720p : 50-60fps with no-delay 1080p : 30-60fps with no-delay 1440p : 20-50fps with dealy
new 720p : 60fps with no-delay 1080p : 50-60fps with no-delay 1440p : 50-60fps with no-delay and small stuffer
on Ryzen1600 and R9 380
And I'm bit confusing with VRAM usage, lipsync and current release don't have big difference. But on my rig, VRAM usage is always over 1GB but there are APU and onboard user.
That's a tough call to make. My own PC should be able to run 1440p no problem (GTX 1060) and it would be better for me since I have 1440p monitor but I'm not sure what setup are other people using. Maybe we should stick to 1080p to be safe? cc @ItaloKnox
I'm running a GTX 970 OC'd so I should be around the same specs of a 1060 6gb. We have the full graphics set already upscaled to 1440p so it's only a matter of testing. For me, we could go with 1440p, but I'm worried about the users running low-spec machines. We shouldn't make the game too hard to run. Also, stuttering is a no go for me, so if we want to go with 1440p, I would prefer the stuttering to not be there.
Alright then. @P-Chang Do you think you could somehow further improve the performance of 1440p? If not then let's stick with 1080p for now. Maybe we could later make an alternate graphics patch for high performance users or something.
Also can we somehow continue here for the console arcs or should we make the new graphics patches for the main arcs first? I'm not sure if these things depend on each other or not.
My monitor is 1080p so anything beyond that doesn't help me much.
It would be nice to put together separate packages for 1080p and 1440p. I'd say the installer should give users the 1080p ones and enthusiasts with beefier computers can manually install the 1440p ones. Shouldn't be too hard to set up if we already have all the sprites.
Definitely focus on getting things done in the main arcs first, there are far more users on those.
Decompiler say one method is broken, but you can test with this. http://www.mediafire.com/file/3uvmm462bv25oln/chapter1_lip_test_12.24.rar
I deleted old simple routine lipsync in this test so if you don't have voice analyzed file, lipsync never start.
@enumag Stuffer is related in file reading speed, I can't fix it.
@P-Chang Is it possible to pre-load more files to memory? I mean even the worst graphics cards have like 512MB VRAM which should still easily load dozens of 1440p images. Of course it might not be possible with the engine. By the way are you using SSD or HDD? I have a new super-fast SSD drive connected to M2 slot instead of normal sata. It might work alright on such high-end setup. I'll have to try it later.
SSD SATA 600MB/s
Pre-load is probably possible. but game doesn't have loading time like we always see in another game. It means I need put it in Launch or MainMenu or Hotkey, I can't think it is good.
And I can't know how game use VRAM in low end. probably engine optimize it. but in my rig, VRAM usage is over 700MB in Launch.
Personally it kindness for drive, if I made it for only me, i implement it. but I think always keeping texture cause incomprehensible issue.
I'm really interested in how M2 slot SSD is faster :D
Is it possible to make the game load in vram only the sprites used in the script you are currently playing? I don't think it's a big problem to load it while loading a save or starting a new game. We have a break between the chapters, so unloading the sprites and loading the next sprites would also work.
@ItaloKnox My thoughts exactly. :-)
@P-Chang Well Sata III has limit 6Gb/s which equals 750MB/s - it can't go any faster than that because the slot can't handle it. 600MB/s is pretty close to the limit so very fast for a sata drive.
M.2 however can go way beyond that. According to specs my M.2 SSD (Samsung 960 EVO 500GB) has 3200MB/s for reading and 1800MB/s for writing. Might be enough for 1440p lipsync - I'll be quite disappointed of my SSD if the game stutters.
If anyone wants to check here is the link for all 1440p Sprites with the weather variations: https://mega.nz/#!v80FAbxS!BQdOrCTbR98Yf1FTM-DXiZUEcAj0l0evSP5Ve3wRplg
Just PM me in discord if you need a paid mega account because of the download limit meme
Here's a mirror on my server: http://ichigohi.me/root/Weather%20Sprites.zip
I'll leave it up for a week or so, I'll put it on the server later.
It will come after I completely understand compiler and savedata control and fix scope system bug.
For now. I can do it with only regex in uncompiled script. I won't do like that.
Is there a difference in your PC?
@Grelo As fas as I can tell they look identical.
@Grelo Oh I see the difference now. The top one is better.
and these?
Ok thanks.
The second set seems to be the same thing in 1440p - maybe the difference is more subtle because it was harder to see. The top one is again better in my opinion but I would never notice any difference without looking for it. EDIT: Actually I'm not 100% sure if there is a difference in the second set - there was in the first set though.
I had to zoom in to see the difference. Top one looks slightly better, it has smoother lines. But really, they're essentially the same to me.
@Grelo , @irlPM, @enumag
There are a couple enhancements we can make to the sprites in the console arcs release: