07th-mod / hou-plus

4 stars 1 forks source link

Extra cicada BGM calls in mehagashi #9

Closed drojf closed 7 months ago

drojf commented 7 months ago

Cicada ambience doubled/too loud?

We had the following report:

I have a feeling that something's wrong with Mehagashi. It feels like I've been hearing the cicada ambience track non-stop, even in indoors scenes where it makes no sense. There was even a part where the UI reported that two instances of it were playing at once.

Weird. I'm no longer hearing it, yet the UI claims two instances are playing.

image

I can see only two cicada ambience calls which don't exist in the base game. Were these added on purpose?

I did notice that when keichi is in the changing room it keeps playing (this is due to this new call only in our mod, same as above): https://github.com/07th-mod/hou-plus/blob/fe82c4b087a57a3752ec7c27afadc2ff2bea7e24/Update/mehagashi.txt#L708-L713 . Although, I guess, if we're doing this by logic, you would still be able to hear cicadas in an open changing room with no doors, but it would be quieter.


There was even a part where the UI reported that two instances of it were playing at once.

This might be due to the engine showing BGM which are set to 0 volume, but are still playing or something like that

orian34 commented 7 months ago

If we can have specific examples of scenes where it plays and it's not supposed to play. But there shouldn't be any from what I had tested.

drojf commented 7 months ago

I guess I'm just wondering why there are additional cicada BGM calls? Were they added in the Hou+ console releases?

edit: weas added in this commit: https://github.com/07th-mod/hou-plus/commit/59d29567cf375672acbcc5d09e5fef2eb46f190f

orian34 commented 7 months ago

I guess I'm just wondering why there are additional cicada BGM calls? Were they added in the Hou+ console releases?

edit: weas added in this commit: 59d2956

The calls were added because I cut up the bgm for some scenes that needed no sound. So ironically there are more calls because I removed the bgm for some scenes to fit the console version. Which is why I don't really get the report saying there's more of the ambient bgm than normal.

drojf commented 7 months ago

Ah, that makes sense.

I think the report was made without comparing directly to the console version. I'll just close this for now unless a direct comparison is made showing the differences.

Having not played the console version before, I would perhaps lower the cicada volume, but if it's like that in the console version then we should keep it that way.

Another thought I had was that the old bgm/GIN's BGM might have an abnormally loud cicada BGM, but I tested and it's about the same, so it can't be that.

orian34 commented 7 months ago

Yeah, what we could see is if the volume normalization has been done for Hou+ or not. Maybe that could explain things.