Patch development thread

[ItaloKnox]

OKAY, not minding I did press enter instead of tab and submitted an empty thread, let me page our MVPs @enumag, @DoctorDiablo, @Grelo and @jwgrlrrajn.

Chapter is up, the scripts are already uploaded. I looked around and it seems to have some minor changes related to the previous chapter, still unsure about what really changed. You'll easily spot some unusual scripts in the dev folder. The main menu also changed, so I guess some more work will need to be done for the graphics.

For now it seems to be a really big chapter, around 60 thousand lines to work. Should take two weeks to finish if I do 5k a day. For now my plan is to go a little over that until my brain melts.

Anyway, discussion goes here. Have fun!

[Grelo]

I quickly checked how does graphic looks in CG folder and find out that names of bgs changed too. Now it seems they are named after their ps3 variants. Moreover i found lots of original bgs dont have their variants in ps3 graphic even main menu bg. This is gonna be fun xD

P.S. Should i wait till you finish voice patch or do something because dunno if it supports widescreen and stuff as it is now.

[DoctorDiablo]

@Grelo Do you want me to put together the basic sprites+backgrounds patch like I did last time, and you can make your changes on top of it?

Also, if you want to get widescreen working, you just have to copy the init.txt file from one of the old chapters and drop it in the update folder.

[ItaloKnox]

In terms of compatibility we're fine. The syntax is still the same and the new scripts doesn't seem to interfere in anything.

If you're worried about making your script changes while I'm working on the voice patch, we can easily merge both patches without any issues. In fact I prefer to merge it this way than having you work with a script with the voice patch already applied, a clean script minimizes the number of conflicts.

[enumag]

Oh my, that chapter is huge! I'm going to run the voice insertion script now. With a chapter of this size it will probably take over an hour. And there is the possibility that I run into some issue with the changes so it might take longer. I'll keep you posted.

[enumag]

@ItaloKnox All done. I need to redo the _meak_023.txt file though because the script inserted way too many wrong placeholders. Don't worry, I'll get it fixed before you get to it. Let me know if you need anything else.

EDIT: _meak_023.txt is fixed.

[Grelo]

@DoctorDiablo I think you dont need to. I think i need to create some bgs manually anyway. Ok hopefully it will not take forever... good luck guys.

[Grelo]

Preview of Meakashi scenario:

Btw I will release the mod after its complete done with cgs, bgs etc. Starting to work on it tommorow i think.

[Grelo]

I decided ill be redoing everything even 4:3 images to 16:9 so this will be even better version than previous ....ill do the same with question arcs later after all is done.

[enumag]

@Grelo That sounds ambitous. And awesome. Consider me hyped. ;-)

[ItaloKnox]

The first batch is ready to go. Making placeholders for lines without voices was definitely the right choice, it was a lot more smoother than I expected. The amount of false positives wasn't that big and it happened exactly in places I expected, so it was pretty easy to fix.

[enumag]

@ItaloKnox Glad to hear that. Let me know if you run into anything you think the script should have handled better. Especially _meak_023.txt and _meak_024.txt seem to have more placeholders than expected (even with the reduction I made earlier). I also removed all placeholders from staffroom.txt - there were only placeholders but no matched voice files so I assume it is not meant to be voiced.

[Grelo]

Guys i need help. Do you know why the changes i made to script like adding cg are not showing in actual game? Even the changes which i deleted are and are not in actual script are showing..... Im stuck. I put it in the update folder btw.

[DoctorDiablo]

If you delete all the files in the CompiledUpdate folder, it will force the system to rebuild them. If it doesn't generate one of the files, then there might be an error in one of them like a missing quote or something.

[Grelo]

I did that too but no help :( and it did generate all the files.

[Grelo]

This is the modified version which i have in update folder and i coppied init file from watanagashi if thats the problem but widescreen works.

_meak_001.txt

[jwgrlrrajn]

Yikes. They changed the file naming system for this one. Ugh. Now I have to manually compare images.

[ItaloKnox]

@Grelo try removing the file from the Update folder, clean both compiled folders and put it in the scripts folder (instad of Update). There's a very strange bug that happens rarely that the game just refuses to load things properly. By the way, if you are loading a save, that might also be your problem.

[DoctorDiablo]

@Grelo I think I found your problem. It's on line 1008 in your updated script, it's missing the second parameter, "maskright" or whatever:

DrawSceneWithMask( "black", 1, 0, 300 );

I copied your new script to the Update folder and it didn't load for me either. So I looked in the output_log.txt in the HigurashiEp05_Data folder and it listed an error on that line.

Failed to compile script _meak_001! System.Exception: 1008: DrawSceneWithMask - Parameters were not of expected type!

[Grelo]

@DoctorDiablo Wohoo, thanks that indeed was the issue. I can finally continue now.

[ItaloKnox]

If anyone here is feeling like doing idle work, can you guys check the "known issues" section and try to find the voices in the PS2 files? _meak_012.txt is probably the hardest one, but the others shouldn't take much time.

[enumag]

@ItaloKnox For the first mistake it seems that on PS2 there were these two voices, https://www.dropbox.com/s/cdnez8432vprf3m/150600178.ogg?dl=0 and https://www.dropbox.com/s/98kgrqd7b99iznv/150600179.ogg?dl=0. Later on PS3 those two lines were combined to one https://www.dropbox.com/s/fmvf5ob2wdckek4/n_150600178.ogg?dl=0. At the moment the script has the PS2 lines but voices the PS3 variant. Which one do you prefer? (I've a commit prepared for the PS2 variant.)

For the second issue I found this voice, please check if it matches what the script says. https://www.dropbox.com/s/obmust3cfvksjo5/omoa15009.ogg?dl=0 (I've a commit prepared.)

I don't know how to locate the files for the third and fourth issue.

[ItaloKnox]

Thanks! Looks like they match perfectly. Since I was already with everything open, I committed the files and pushed them into the repo. Thanks again, I'll look for the remaining files after I finish the voice patch (probably tomorrow).

[enumag]

@ItaloKnox Actually I think your fix was not entirely correct so I have overwritten it with mine using force-push.

[ItaloKnox]

I guess you're right, though for some reason it looks okay on VS Code. 🤔

[enumag]

Wow it's such a long chapter but you're almost done already? I mean only a few days and the tips are left. You really work quickly. 👏

When you're done don't tag a release right away. I need to run it through my compiler to fix the case sensitivity thing first.

[ItaloKnox]

That's all thanks to the voice placeholders, couldn't go as fast if they weren't there. At first I was expecting 4 or 5 scripts a day (and that would be already pushing myself) but doing 8 a day was a lot more easier than before. I could even push it further and to it in two days, but since the graphics patch will take a while, I won't rush the release.

[Maelstrom1]

Speaking of the graphics patch, what's the timetable on that?

[enumag]

@Maelstrom1 We don't really have any at the moment, depends on @Grelo. However isn't quality more important than speed? ;-)

[Grelo]

Guys im giving it my all. Its easily the hardest chapter for now, so many edits. Maybe tommorow ill finish first half.

[ItaloKnox]

Don't worry about the speed, if we can get it finished in two weeks I think we're good. The voice patch always come out early so if anyone is eager to play they can get that. The more time we take to finish it = less bugs we have to squish.

[Grelo]

True :) . Anyway do you guys know why meakashi doesnt have textbox? Its displaying on some filtered screen and it doesnt look good.

[ItaloKnox]

You mean the vanilla game? I always thought every 07th Expansion game had no textboxes, it was always the plain transparent black filter. Maybe I'm not recalling correctly, but that's what I remember.

[Grelo]

So will you make it on release, or can i make it someway? Dont need it now anyway.

[enumag]

@Grelo I think you just need to replace the windo_filter.png in the CG directory with one from our older patches. Plus the init.txt script in the Update directory. That should do the trick.

Also don't rush it unnecessarily. You have a lot of work to do and it's easy to make mistakes. It's much better to do it slower but well than to have a rushed buggy patch. Take as much time as you need. ;-)

[Grelo]

@enumag thanks it works, so easy, didnt thought it would be in cg folder.

[Grelo]

How does the new unlock scenarios look? I will make similar ones for question arcs in the future.

[enumag]

@Grelo I only have one word to describe them: gorgeous. 🥇

[Grelo]

Btw i made 16:9 HD versions of notes in original folder too. They are displaying on whole screen now. Dont know if its good or bad. Practically everything is 16:9 now.

[enumag]

I prefer 16:10 :trollface:

It is better to have it consistent I think? It doesn't matter much for the notes though. I mean it's just blackscreen anyway.

[Grelo]

Example:

[ItaloKnox]

For the notes it doesn't matter that much, but I still think it's better for people with high resolution displays. If we're going to have the best version, then I think it's a good effort.

By the way, the scenario screens look beautiful. Great work!

[DoctorDiablo]

Wow, _meak_012.txt was missing a lot of voice files. I found them all (I think) in the PS2 sound files, so I should be able to add them in pretty easily.

And nice work on the graphics, @Grelo!

[ItaloKnox]

Yeah, the PS3 release is a shitfest compared to the PS2 version. So much stuff changed or removed, sometimes I prefer to leave voice files out instead of censoring the text. For now I only changed (and translated) two sections, and I hope it stays this way. Anyway, if you can get the voice files in place for me, I would really appreciate that.

[DoctorDiablo]

I fixed all the voice issues except the one that mentioned changing the translation, which sounded a little scary.

[ItaloKnox]

Thanks, @DoctorDiablo, I'll take a second look at that to see what is the best route. There's now a few (a lot?) more, so if you can do these as well I would be grateful. If you can't, no problem, I'll come back to them after tomorrow.

Also @enumag, can you look at the newest commit? I'm not sure what the hell happened, but for some reason the voice inserter thought it was good to put a bunch of S02 voices in the last three scripts. It was kinda hellish and took a lot of time.

Maybe for a future version can you include a blacklisting feature? Use the first two scripts as a sample, get the most common folder (in this case it was S06 for the whole game -- but dunno about the tips) and use it until the end.

[enumag]

@ItaloKnox Sorry about that. I'll look into it tomorrow and hopefully find some solution. Blacklisting based on the first few scripts doesn't feel right - what if an error like this occured in those. The lines are completely identical so prefering s06 based on previously matched lines is indeed the only available solution.

Also I wanted to ask ane more thing. How often does the script insert a voice file somewhere outside of a dialogue? Should I disable insersion completely when outside of quotes?

[Grelo]

@ItaloKnox Dont change the text pls :( . Btw graphic patch progressed a lot so.....soon :P

[ItaloKnox]

@enumag It's not actually that common to see voices outside of a dialog. I actually prefer the way it is right now, the only issue I had was with the S02 fiesta that slowed me down a lot. Don't feel bad about it, what we have right now is the best, it flows better than ever.

@Grelo tbh I'm very against changing the translation, so I only do that in very minor issues. In this chapter there are a lot of graphic scenes, so no way I'm changing them or removing them because we can't have them voiced. Some minor stuff like copyrighted references or the last one where I changed from "are you drunk" to "did you put an all nighter" (so the voice line would match, of course) are ok with me. As long as it doesn't change the meaning, remove content or make it less fun I think it's fine. But if anyone disagrees, we can always discuss it, since the patch is a collaborative effort and everyone has a say on it.

[DoctorDiablo]

@ItaloKnox I fixed some more of the missing voices. There were two voices you said were censored and didn't match the text, but the PS2 audio files sounded the same as the PS3 version (at least as far as I could tell?) so you can double-check those.

[Grelo]

@ItaloKnox If the meaning is preserved its ok or the way you described it. I meant removing big chunks of text due to missing voices.