search

07th-mod / meakashi

19 stars 16 forks source link

Tips BGM #14

Closed P-Chang closed 5 years ago

P-Chang commented 7 years ago

In testing dll, I realize almost of BGM for Tips is not played correctly. Almost of BGM is set before "DrawScene". I exchange sort, these are played correctly.

Probably "DrawScene" reset BGM.

But I cannot discriminate it is related in vanilla or edited dll or my savedata is collapsed. Could someone check it?

orian34 commented 5 years ago

BGM are reset because they are following the BGM cleaning without any stop inbetween. Switching works because you have the DrawScene cutting the FadeOutBGM methods from happening at the same time as PlayBGM.

It's a vanilla issue.

Though that's only what I think the issue is. Considering I fix those, anyone is free to close it if there's nothing more to add.

orian34 commented 5 years ago

Considering just deleting the BGM cleaning without swapping the methods makes it work, I'm fairly certain it's related. Who knows what it could really be though.