search

07th-mod / meakashi

20 stars 16 forks source link

CG shows Rena staring at Keiichi instead of Shiion #21

Closed ghost closed 6 years ago

ghost commented 6 years ago

CG/scene/002a.png is used in Meakashi, but is from Onikakushi. Rena is talking to Shiion but the CG shows her staring at Keiichi. @Grelo pointed out this needs to be zoomed in to show only rena's face. I'm not sure whether this means there is a separate CG for that or we need to script a zoom on the existing CG for that.

Grelo or @enumag do you know which is the correct answer for that?

enumag commented 6 years ago

The new graphics patch was mostly compiled automatically so this one is wrong. The previous patch used zoom to show only Reina (variant with Shion does not exist as far as I know). I'm not exactly sure how it was on PS3 though.

Easy fix is to just replace it with zoomed version. I think that's good enough at least until orian gets to Meakashi.

Grelo commented 6 years ago

PS3 used the exact same zoomed face image like we used. I made it so it is like in PS3.

DoctorDiablo commented 6 years ago

If we want to handle the zoom in the script, the system is capable of it. I recently did something like that here in the console arcs. The 3rd, 4th, and 5th parameters in DrawBustshot are the x/y/z coordinates. Making the z value a larger negative number zooms in more, and tweaking the x/y coordinates can shift it so it zooms in on the right location.

Grelo commented 6 years ago

Still surprised this is not fixed yet as there are more issues like this. For someone this could be definitely "game breaking".

ItaloKnox commented 6 years ago

We have a pending (big) update for Wata and Tata, and also Tsumi on the plate. Unless someone who's idle commit it I doubt anything can be done about it right now. But yeah, I think we should have fixed this sooner.

enumag commented 6 years ago

In the worst case it will be fixed when Orian gets to Meakashi. And knowing him it actually won't be that long.

orian34 commented 6 years ago

handled