07th-mod / meakashi

19 stars 16 forks source link

[BGM] hig_sample_kyouki.ogg has unpleasant and possibly damaging high pitched frequencies #54

Open BFCE opened 4 years ago

BFCE commented 4 years ago

This is present with and without 07th-mod

Steps to reproduce: A. play BGM/hig_sample_kyouki.ogg or B. Load into this save file: save005.zip

The harsh noises are plainly heard around the 10 second mark

ItaloKnox commented 4 years ago

We talked yesterday on Discord, but I need to elaborate here further, so we can decide on what we're going with.

For everyone who is not aware, it is for a fact that the frequencies around 15kHz are way too much. It's so much you can't even read it: Studio_One_2020-05-13_11-17-45

BFCE commented 4 years ago

Version 2 of your edit is almost perfect if we still want to maintain parts of this effect, but given the ending (which is made up of much of the same frequencies) and the erratic behavior of it, I'm still not entirely convinced the effect was intentional in the first place. (Mind you, I don't think the ending ever actually plays in game. It loops before that section)

I should also note, you first start hearing the sounds around 10 seconds into the file, which is the section I've been using for comparison

ItaloKnox commented 4 years ago

Looks like clyp is doing something to the music (probably replaygain?), so the issue kinda got lost on it. I edited the previous post with new links to Dropbox.

We also briefly talked about the possibility of adding your version to the installer as an optional download. That means people can choose between the original or your version that has the issue basically gone. That seems to be the most balanced option we have right now instead of going with a one size fits all approach. I'm okay with leaving my versions behind if that means we can make everyone happy.

BFCE commented 4 years ago

That would be a good solution. I should also note that this sound file might be in the other Kai games as well. I haven't checked, as I only discovered this issue through actual gameplay