search

07th-mod / meakashi

19 stars 16 forks source link

Incorect poem text #73

Closed drojf closed 3 years ago

drojf commented 3 years ago

We had a report about this, and I don't see it in the list of open issues:

I saw another glitch in Meakashi, the end of the poem that shows before Shion meets Keiichi has a part from the ending of Meakashi instead of what it should say. (The line should "Would it have been better if I wasn't born? This bloodstained hand couldn't even grasp the air." )

Edit 2021-02-21:

The incorrect text right now is "I ran away from baseball practice. I stepped onto the street when the light was red, and got hit by a motorcycle. I've been in a coma since then but I've finally woken up.

drojf commented 3 years ago

OK, this sequence occurs at the very start of _meak_015_1.txt.

Can be seen in this video https://youtu.be/S5jPdqArse8?t=10672

I looked into this, and the culprit appears to be this pull request: https://github.com/07th-mod/meakashi/pull/70 which adds the file CG/text/monologue_mea4.png to this repository. However the contents of this image is completely different from the image which we have in our graphics pack, which is overwritten during the install

The image in this repository (CG/text/monologue_mea4.png):

The image in our graphics pack (CG/text/monologue_mea4.png): monologue_mea4

I'm not sure what what image was supposed to be replaced in the PR, but I guess it got mixed up. Deleting the image from this repository and doing a new release would fix the issue

drojf commented 3 years ago

Should be closed by c9a1b86, released in https://github.com/07th-mod/meakashi/releases/tag/v5.1.2