search

07th-mod / meakashi

19 stars 16 forks source link

Fix BGM switching for Answer Arcs and Rei #80

Closed drojf closed 1 year ago

drojf commented 1 year ago

Before we implemented BGM switching, some BGM were copied directly into the BGM folder. While we removed most of these, the Answer Arcs and Rei still copy certain BGM to the BGM folder. These BGM won't work correctly with our BGM switching function - the pre-april update BGM will play no matter your choice of BGM.

These BGM are mostly just BGM copied from the Question Arcs so they can be used in the Answer arcs. The reason this was done was so that we could better match the Console game, which uses these QA BGM.

As an aside, we also include one? BGM which does not overwrite anything (from the console game). This can be treated the same way as the rest of the files, see below.

To fix this issue and avoid future confusion, these BGM should be included in our BGM archive. Currently, these extra BGM reside in:

For the BGM which are copied from the Question Arcs, we need to copy both the Post-April Update version, but also the Original Version. Other Console Specific BGM only have one version.

It would technically work if we copied these to the BGM/OGBGM folders, but it might be better to put them in separate folders (ExtraBGM and ExtraOGBGM?). Generally I've always thought of the BGM folder to never be touched, as that should only contain files that come with the game. But I haven't decided the best way to do this yet.

Once those files are in place, we just update the game script (if necessary) to search for the extra BGM in the other folder (if necessary).

TODO

Rei TODO

This is optional, it would only tidy up the Rei BGM. Considering it's just one file, probably not worth the trouble.

drojf commented 1 year ago

Here are the extra BGM and SE used for each chapter (ep8 uses no extra BGM)

├───HigurashiEp05_Data
│   └───StreamingAssets
│       ├───BGM
│       │       hm05_20.ogg
│       │       msys01.ogg
│       │       msys03.ogg
│       │       msys06.ogg
│       │       msys07.ogg
│       │       msys08.ogg
│       │       msys09.ogg
│       │       msys15.ogg
│       │       msys17.ogg
│       │       msys23.ogg
│       │       msys27.ogg
│       │       msys30.ogg
│       │       song_you.ogg
│       │
│       └───SE
│               wa_001.ogg
│               wa_003.ogg
│               wa_005.ogg
│               wa_006.ogg
│               wa_007.ogg
│               wa_011.ogg
│               wa_012.ogg
│               wa_013.ogg
│               wa_016.ogg
│               wa_018.ogg
│               wa_019.ogg
│               wa_020.ogg
│               wa_022.ogg
│               wa_023.ogg
│               wa_025.ogg
│               wa_027.ogg
│               wa_032.ogg
│
├───HigurashiEp06_Data
│   └───StreamingAssets
│       ├───BGM
│       │       msys06.ogg
│       │       msys07.ogg
│       │       msys08.ogg
│       │       msys17.ogg
│       │       msys23.ogg
│       │       msys30.ogg
│       │       song_ps2ed1.ogg
│       │
│       └───SE
│               thunder.ogg
│               wa_001.ogg
│               wa_003.ogg
│               wa_007.ogg
│               wa_011.ogg
│               wa_013.ogg
│               wa_023.ogg
│               wa_025.ogg
│               wa_041.ogg
│               wa_045.ogg
│
└───HigurashiEp07_Data
    └───StreamingAssets
        ├───BGM
        │       msys06.ogg
        │       msys15.ogg
        │       msys17.ogg
        │       msys23.ogg
        │
        └───SE
                wa_001.ogg
                wa_003.ogg
                wa_007.ogg
                wa_011.ogg
                wa_016.ogg
                wa_033.ogg
                wa_036.ogg
                wa_041.ogg

└───HigurashiEp08_Data  // No extra BGM or SE used in this chapter

And when merged together:

├───BGM
│       hm05_20.ogg
│       msys01.ogg
│       msys03.ogg
│       msys06.ogg
│       msys07.ogg
│       msys08.ogg
│       msys09.ogg
│       msys15.ogg
│       msys17.ogg
│       msys23.ogg
│       msys27.ogg
│       msys30.ogg
│       song_ps2ed1.ogg
│       song_you.ogg
│
└───SE
        thunder.ogg
        wa_001.ogg
        wa_003.ogg
        wa_005.ogg
        wa_006.ogg
        wa_007.ogg
        wa_011.ogg
        wa_012.ogg
        wa_013.ogg
        wa_016.ogg
        wa_018.ogg
        wa_019.ogg
        wa_020.ogg
        wa_022.ogg
        wa_023.ogg
        wa_025.ogg
        wa_027.ogg
        wa_032.ogg
        wa_033.ogg
        wa_036.ogg
        wa_041.ogg
        wa_045.ogg

Here is an archive with the merged BGM files for chapters 5-7: https://1drv.ms/u/s!Ar-lAVeetlqhhL1cwSQQaZpUNEQGjA?e=FUlSsJ

drojf commented 1 year ago

Here is an 'Extra BGM Pack' containing the bgm + folder structure to be merged with the existing Kai BGM pack we use.

I realized yesterday that the question arcs OGBGM/OGSE are likely never used when you have the OGBGM/GIN BGM setting on, because GIN's scripts wouldn't reference them. But since it only adds 21Mb overhead, I've add them anyway.

extra bgm pack: https://1drv.ms/u/s!Ar-lAVeetlqhhL1objObUOZJT9jE2Q?e=wHcVfU

drojf commented 1 year ago

I've created an updated version of the Answer BGM pack.

https://1drv.ms/u/s!Ar-lAVeetlqhhL4mTrUjjeWnAYs5PA?e=DDe3JP

The following changelog is included inside.

Version 1.1 - 2022-11-04

Here are the different versions of those three modified BGM if you want to compare them bgm comparison

drojf commented 1 year ago

This issue should be fixed now.

drojf commented 1 year ago

I just noticed there are the following BGM and SE in the Ch8 Voices archive (previously I thought there were no extra BGM/SE used in ch8):

Unfortunately, msys32 is not included in the BGM archive I updated, so I'll need to update it to add that one.

TODO