search

07th-mod / meakashi

19 stars 16 forks source link

Missing voices #9

Closed enumag closed 6 years ago

enumag commented 7 years ago

@ItaloKnox There seem to be some missing voices in this section. s06/01/150100048 is used, then no voices for several lines and then s06/01/150100054. Looks like voices 49-53 should be added somewhere in there. Can you do it? I'm lost here without understanding japanese.

EDIT: s06/01/150100056 and s06/01/150100058 are also missing (58 is only among PS2 voices). s06/01/150100057 doesn't seem to match the line where it was added so I commented it out.

ItaloKnox commented 7 years ago

Oh, I think I said something about this issue before. The thing is: we have no voices for this scene and the PS2 voices are also censored. If I recall correctly, the script just skips these lines and call it a day. I'm not really sure about what we should do.

ItaloKnox commented 7 years ago

Double posting because you might have seen the reply.

This one wasn't skipped, I just got it wrong. Give me a couple minutes to check and fix it.

ItaloKnox commented 7 years ago

Huh, nope, I don't think we can fix it without translating. It was pretty much censored and the voices don't really fit in.

I'm not feeling all that well today (feels like everything is going too fast), so I'm sorry for the confusion. I'll see if I can translate it later, but honestly I wouldn't like to censor the text.

enumag commented 7 years ago

Personally in cases like this where the censored part is replaced with different lines rather than just outright skipped I usually prefer the censored but voiced version. I mean we're trying to port Sui so it's probably best to keep as many voices as possible.

enumag commented 7 years ago

But of course it's up to you. Also take as much time as you need to recover, There are some fixes I need to do in this section but I have more than plenty of other things to fix elsewhere so no rush.

Grelo commented 7 years ago

Just dont censor text please. Everything but that.

enumag commented 7 years ago

So... leave as is then? @ItaloKnox Just tell me your verdict if you want to do something about this or not.

ItaloKnox commented 7 years ago

I think we should leave it uncensored, at least for now. I'm not satisfied with my translation so we should stick to the higher quality text and since it's just a very small part, I think it's not such a big issue.

Let's revisit this in the future.

enumag commented 7 years ago

Ok. I'll leave the issue open and move on to the other issues in the script. Thanks.

enumag commented 7 years ago

@ItaloKnox Is this voice (from PS2) good for this line?

ItaloKnox commented 7 years ago

It ends the same but it is completely different. There's no much stuff going on there that I can only read but not understand a thing, actually. lol

Norgus commented 6 years ago

Added the files in, some of them only appearing if you have the censorship set relatively high (4/5). I allowed similar lines to play in the uncensored version.

https://github.com/07th-mod/meakashi/commit/ba4ad2cb0f21c8ab95372af492de335824800531