07th-mod / python-patcher

Mod Installer for the Higurashi and Umineko Games
158 stars 12 forks source link

Incorrect "Confirm Exit" popup placement when trying to close installer #125

Closed miere43 closed 4 years ago

miere43 commented 4 years ago
  1. Run 07th-Mod.Installer.Windows.exe
  2. Press Run Installer
  3. Wait for browser/installer to load
  4. Minimize installer window (not the browser)
  5. Close window using taskbar: image
  6. Unminimize installer window
  7. Close installer popup is placed in top-left corner and is very small: image

Expected result: image

Bug only happens when window is minimized, doesn't happen if window is in the background.

One way to fix the problem is to call SetForegroundWindow on installer window after user executes step 5, then enqueueing popup display to the next IMGUI frame.

drojf commented 4 years ago

Thanks for reporting this! I ended up doing what you said, and it seems to work without having to queue the popup for on the next frame.