Closed drojf closed 3 years ago
The above commit caused an issue where people running a language patch would have English text.
It was because the game would have the English compiled scripts, but the French raw scripts. The game wouldn't re-compile the scripts, so they'd see the English scripts.
I fixed this in https://github.com/07th-mod/python-patcher/commit/73cf6066d9aa8b6c057ee0735a7cbf6c1a028809 and haven't had any issues since, so I think this issue can be closed.
We are in the process of distributing compiled scripts for all games (not just the console arcs) to fix problems a small number of users are having compiling scripts - see this issue: https://github.com/07th-mod/higurashi-patch-compiler/issues/62. This also will avoid the black screen on first startup when the game is compiling scripts.
I realized that the our installer automatically clears the scripts in the
CompiledUpdateScripts
folder just before extracting files, even if scripts are not to be extracted. This will mean that if a user is doing an upgrade of their Higurashi install, and aren't installing thescript
archive, the next time they boot the game, they'll have to compile scripts themselves.Therefore, to be strictly correct, the installer should only clear the
CompiledUpdateScripts
if thescript
pack is being installed.The main clearing we do at the moment is as follows (there might be some other clearing in the code I missed though):
CompiledUpdateScripts
: cleared on any install or updatedCG
andCGAlt
: cleared on a first install/full install, but not on updatesharedassets0.assets
: backed up tosharedassets0.assets.backup
if not already backed up