07th-mod / python-patcher

Mod Installer for the Higurashi and Umineko Games
158 stars 12 forks source link

Check if user is running installer under wine/proton and give a warning #171

Closed drojf closed 2 years ago

drojf commented 2 years ago

We have had some reports from Steam Deck users that their game doesn't run properly, showing a pink box where text should be.

Honeyview_steamdeckhigurashiissue (2)

The problem was the game was run under Proton, but the mod was installed using the linux version of the installer. This would install the linux mod files, which don't work under Proton (...or there was some other issue with Proton, as we haven't really tested under Proton).

I don't think we want to properly support Proton for now (perhaps in the future if we have someone who can test it for us we could), so I want to abort the install/show an error message if it looks like the user is using Proton

I think the best way to resolve this is to abort the installation if the user has the Windows version of the game installed, but is running the game under Linux.

For Higurashi, you can check if the Windows version of the game is installed by checking for HigurashiEp01.exe (instead of HigurashiEp01.x86_64 for linux).

For Umineko, it appears that the lib64 folder is not installed on Windows, see https://steamdb.info/depot/406552/. However, we extract a lib64 folder ourselves on all platforms with a couple files in it. So rather than checking for the lib64 folder, it would be better to check for lib64/libfreetype.so.6 which we do not provide, so that this check will always work regardless of what you've done to the game folder in the past.

It would be nice to show this warning before you start the install, but I think for now checking after the install starts is the easiest way.

The warning should link to a steam page which tells you how to enable/disable proton.