07th-mod / python-patcher

Mod Installer for the Higurashi and Umineko Games
150 stars 12 forks source link

Add 'Download manually, but install automatically' option #188

Closed drojf closed 1 year ago

drojf commented 1 year ago

The installer doesn't have a proper option to download the files yourself (to use your own download manager, or because our installer's downloader doesn't work properly).

Theoretically all we'd need to do is skip the download stage, and point the installer to a specific folder (for example, the installer could come with a folder called "Manual Downloads" and you'd just place the files in there.

But to make it more user friendly, the installer should display a list of files for you to download, and maybe even show a tick mark against each file once you've put it in the "Manual Downloads" folder.

There is also some complication with some Umineko downloads, where I have used the .metalink files for download links, but due to the naming scheme I've used, removing the .metalink should provide a direct link to the file to be downloaded. So that shouldn't be a problem

I'm not sure if we should automatically delete downloads when the install finishes successfully - personally I wouldn't want the installer to delete the downloads automatically in this situation.

In the future, if we implement batch installing chapters, you may want to provide ALL chapter's files. In which case, we should be careful to never have two files with the same name between chapters (otherwise they would overwrite each other). Another way around this besides having unique names is to have subfolders in the "Manual Downloads" folder, one per mod/mod-variant? Need to think about the best way to do this without making it confusing for the user where to put the files.

drojf commented 1 year ago

This has been added in #189