07th-mod / python-patcher

Mod Installer for the Higurashi and Umineko Games
150 stars 12 forks source link

Launch Webview on Linux/MacOS #195

Open drojf opened 1 year ago

drojf commented 1 year ago

So to give some history, I've mostly finished adding a webview via Rust's wry library, see https://github.com/07th-mod/python-patcher/pull/186. It is more complicated than it should be, because I need to figure out the port the python script has launched on, and pass the information from Python to Rust via a file.

In addition, this only currently works on Windows, because we only produce the rust install loader on Windows - on MacOS and Linux we just distribute the python scripts.

However, recently @andOlga mentioned that there's a much easier way to launch a webview on linux, which is essentially the same thing that wry does, which is to just directly call msedge to launch a webview like:

subprocess.run([
    "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe",
    "--app=https://www.google.com",
    "--user-data-dir=c:\\temp\\webview"
])

Because we can call this from Python, doing it this would simplify things quite a bit, however given that I've mostly tested and finished the Windows-only Rust version, I will probably just go with that for now. Some of the changes I've made would also still exist even if we use the Rust version.


Coming back to the point of this issue, If we want to launch Webview on Linux/MacOS, we might be able to use something similar to the above (launched from the Python side):


Another (better) alternative suggested by andOlga was to use https://github.com/r0x0r/pywebview , which behaves pretty much the same as Rust's wry library.

We need to setup using external libraries in the installer. andOlga suggested shipping venv and activating it before we run the installer. I'm not too sure how venv works, but if we can't directly include the packages in a venv in the installer, we could create a venv and install packages to that venv at runtime, assuming it doesn't make the installer take too long to start up.

Also, if it is possible to use this across all platforms, and it has no missing features from the existing Windows wry based webview, I would just use it across all platforms to keep it consistent and remove our wry webview


PyOxidizer (https://github.com/indygreg/PyOxidizer) was recommended as a way to deal with distributing python with included libs. Previously I had tried using pyinstaller (can't remember what happened), but I haven't tried pyoxidizer before.