07th-mod / python-patcher

Mod Installer for the Higurashi and Umineko Games
158 stars 12 forks source link

Installing Console Arcs onto an existing Modded Ch.4 installation does not force a full re-install #204

Closed drojf closed 1 year ago

drojf commented 1 year ago

Installing Console Arcs onto an existing Modded Ch.4 installation still gives the option to update or reinstall, when it should only give you the option to re-install (or rather, behave as if it was the first time you installed the mod).

It looks like it just treats it as an existing Console Arcs install, and attempts to update it according to the installedVersionDAta.json versions, even though it's a different mod.

The installedVersionData.json contains the correct information about what was last installed in the id field, (eg. "Himatsubushi Ch.4/full"), so something isn't working correctly.

Also see https://github.com/07th-mod/python-patcher/issues/129

drojf commented 1 year ago

I re-checked this and actually it does detect that every file needs update with

Full Install Required to overwrite existing mod - [Himatsubushi Ch.4/full] is currently installed, but want to install [Console Arcs/full]

So the issue isn't as bad as I thought it was. I'm not sure if I imagined it earlier, or I accidentally clicked Ch.4 instead of Console arcs.


However it still shows two buttons (one for update, one for re-install), despite every file needing update.

I was thinking about how to make it only show one button, since I thought both buttons did the same thing, but actually they do slightly different things:

Given that both buttons will do the right thing, and that in some cases you may really want to clear the version data, I'm just going to leave these buttons in for now rather than try to fix it.

For now, I'll add a small subtitle under each button so you know the exact difference in this kind of scenario (that re-install will clear the version data)