Open drojf opened 4 years ago
Oh oops I already made a curl patch and totally forgot to actually merge it, I'll do that in a few hours
Some time ago I created a branch, which replaced all urlopen
calls with a function which could fallback to aria2c (except for the call which tellowkrinkle already applied, which requires the use of CURL). I didn't push this to mainline because it didn't actually fix any bugs at the time.
Just recently, a MacOS user had the same SSL error as above, but at a different time (on startup).
What happened is, just recently we enabled/fixed HTTPS redirects from non-https urls (previously it was the reverse - some HTTPS urls would redirect to HTTP). The side effect of this was that any urlopen calls, even when called with HTTP urls, would now be redirect to HTTPS urls, and cause the MacOS SSL error.
To fix, this I applied the code changes from my old branch to the current code (this commit: https://github.com/07th-mod/python-patcher/commit/8cd2de35778d3cd57b3884562924d69445a61877 - note that I messed up the commit description - it uses aria2c, not CURL for the downloads)
The user reported that the problem was fixed after trying the new installer, so I assume the above commit fixed the problem.
I feel like this issue might crop up again, so I'm not going to close the issue just yet.
We had two types of errors reported recently:
This issue is not yet resolved
One issue was getting "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1108)>" on startup (just after checking aria2c and 7z)
This issue is not yet resolved
"urlopen error [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:590)" During URL querying:
(they were running "OpenSSL 0.9.8zh 14 Jan 2016")
edit: trialing a workaround using CURL instead of python's URLOpen, lets see how that goes...