search

07th-mod / tatarigoroshi

30 stars 11 forks source link

tata-012 fork #40

Closed enumag closed 6 years ago

enumag commented 6 years ago

@P-Chang Here is another mild censorship candidate for a fork - the voices I added probably don't match the text. I assume you want me to report cases like this, right?

P-Chang commented 6 years ago

https://github.com/07th-mod/tatarigoroshi/commit/b82ad394d16920fe7dd347796463b0d18c193f43 Thank you, I finished it.

enumag commented 6 years ago

@P-Chang Thanks! By the way I noticed you added forks to Watanagashi, possibly other chapters. Are these forks missing translations too? If so, can you mark such lines so that @ItaloKnox or @DoctorDiablo can go through them easily in a batch?

P-Chang commented 6 years ago

These changes in watanagashi are for just including name line and line break. And adding name lines in uncensored lines. And fixing some double quotation and　"「」" .

I decided GCensor branch must have name to line break or Line_Normal or LinemodeSp for I don't break your scripts.

enumag commented 6 years ago

Are you sure? When I compare some of the zwata files there are quite a few cases with the japanese text being different for each branch but english test being the same... Is there really no need for translation?

P-Chang commented 6 years ago

Hmm, these are just merge from Norgus changes.

Probably, he translated almost dialogs that must be. Dialogs that he leaved are seems like have only one or two word difference, or completely broken Japanese for nuance.

If I increase change, I'll add comment. but Judging old changes are bit hard for me.

After fixing current issue, if I can find missing translation, I'll add comment.

ItaloKnox commented 6 years ago

Shouldn't it be easier to compare commits instead of going through the translation again?

enumag commented 6 years ago

If these are all changes by Norgus then it's fine. I trust his judgement.

P-Chang commented 6 years ago

@ItaloKnox Sure. these branch file in chapter2 have all translation of previous version. And files of chapter1 that I'll make it in future have these too.

enumag commented 6 years ago

@P-Chang What needs to be done here? Do we just need to fix the translation?

P-Chang commented 6 years ago

@enumag If you want to make it perfect, translation is needed. But scene and dialog flow don't have big difference, there is no need to rush.