search

07th-mod / tatarigoroshi

30 stars 11 forks source link

ModEnableNVLModeInADVMode issues #48

Closed enumag closed 6 years ago

enumag commented 6 years ago

@P-Chang I'd like to fix #46 by forcing NVL mode for that part of the game. It doesn't work as I expected though.

  1. The windo_filter.png for that we have NVL mode is not used.
  2. It seems that GetGlobalFlag(GADVMode) still returns true which messes up the intended screen breaks.
  3. The text positioning is different than in normal NVL mode - but I should be able to fix that myself in init.txt.
P-Chang commented 6 years ago

It can't use GLinemodeSp flag for screenbreak because I use it for detect this mode in save and load, so you need replace these to Line_WaitForInput.

Although, name line is not needed in this mode.

If replacing GLinemodeSp have trouble with your scripts, I'll make another logic, but it need your idea.

You can use ModNVLADVModeSettingLoad that was writed in init.txt. and I think current setting is not good one, but NVLMode and NVLADVMode need bit different setting for better looking.

enumag commented 6 years ago

Ok I think I'll just remove all conditions for ADV-mode in that part. That should solve the issues with GLinemodeSp and GADVMode because they won't be there.

So the only thing I think I need from you is to solve the windo_filter thing. Is that possible?

P-Chang commented 6 years ago

I put windo_filter_nvladv.png( edited vanilla one ) in test edit, so I think current mod CG folder have it, if you change it that you want, it should be change.

But I think current filter are good in this mode, I bit forget about scene that you are working now. I made it for Oni opening scene and Ending and Tips Typewriter and Note scene.

vanilla filter make all to darker so I dislike it, but scene that need this mode are dark scene and don't have character sprite.

How do you think of it?

enumag commented 6 years ago

Ok I'll leave it as is for now. Thanks!