07th-mod / tsumihoroboshi

14 stars 8 forks source link

Few sprite issues #37

Open turnitoff92 opened 4 years ago

turnitoff92 commented 4 years ago

Characters standing on top of each other

20191208114111_1

Rika's sprite won't go away

20191208135122_1 20191208135109_1 20191208135413_1 20191208135440_1

Characters standing on top of each other again

20191208135605_1

Something weird is happening there, either issue is with Rika's own OG sprite, either it's that Rika's sprite that won't go away again, but she's absent in different art style modes

20191208135836_1

20191208140309_1

ItaloKnox commented 4 years ago

The persistent sprite bug is something we've been trying to get rid of for a while already. We deployed a patch that supposedly made it better, but looks like it's not fixed yet. Please take a look at this @idealpersona.

I'll also ask someone more versed at scripting (my role comes very early in the patch, so I'm useless here) to take a look at the other issues.

turnitoff92 commented 4 years ago

I thought she was gone but she's there again...

20191208140643_1 20191208140711_1

She was stuck pretty much permanently until I reloaded the save

20191208142238_1

Also I never realized that characters had different sprites for varying lighting

20191208141003_1

drojf commented 3 years ago

@orian34 We just got another report of this bug with rika getting stuck.

I think last time we worked out that applying this kind of fix could fix the issue: https://github.com/07th-mod/matsuribayashi/commit/56b1622f9f46f4ee4ac357adce239186d2a60250

I asked the user and they said they took the screenshots long after the sprite got stuck, so I'm not sure exactly when the sprite became stuck. If there is something in the script I can search for automatically for when the problem happens, let me know.

Honeyview_SPOILER_unknown Honeyview_SPOILER_unknown2

Main issue: https://github.com/07th-mod/higurashi-assembly/issues/45

orian34 commented 3 years ago

Found one sprite with layer 0, changed it, hopefully should work without issues now

drojf commented 3 years ago

We had another report at part 6. Please keep in mind this is the French version of the patch, but I'll report it here anyway instead of on the french tsumi repo:

No it's tsumihoroboshi (part6) in this scene +Yes it's in French

A screenshot from the scene where the bug happened (no bug in in this screenshot)

Honeyview_SPOILER_unknown-5

The bug:

Honeyview_unknown-4

Update - More info:

It began after the CG with Mion Rika and Satoko and even if he restarted the game by closing it or by loading the save it kept happening

Honeyview_SPOILER_unknown-91 Honeyview_SPOILER_unknown-10 Honeyview_SPOILER_unknown-8

drojf commented 3 years ago

Another report of the very first image posted in this thread

The user installed the game roughly August 7, 2021 ... this makes me realize that we haven't done a new release containing the stuck sprite fixes yet for this chapter...

Honeyview_unknown