07th-mod / umineko-question

94 stars 9 forks source link

Add mode w540@2x flag #159

Closed TellowKrinkle closed 3 years ago

TellowKrinkle commented 3 years ago

Adds compatibility with new ponscripter builds Ponscripter skips characters to the end of the line when it sees a directive it doesn't understand, so by putting the modew540@2x at the end, older builds will stay on default settings (the equivalent of not having it at all)

drojf commented 3 years ago

I'm not sure if you need to make more changes, but if you put all the changes you need in this PR, I can copy the changes to the variant scripts for you (to the voice-only branch etc.), and repeat the changes for the answer arcs too.

TellowKrinkle commented 3 years ago

voice-only doesn't use 1080p right?

modew540@2x puts ponscripter in 960x540@2x AKA 1080p-with-scaled-images mode

TellowKrinkle commented 3 years ago

I set the default to 640x480@2x mode, as that's what the original umineko uses, which would allow you to use that ponscripter build without modifications with unmodded, 1080p modded, and ciconia (uses modew720)

Or at least I think ciconia uses w720, I don't have it so I haven't checked, but the wh-dev branch added w720 and w1080, and had 2x mode disabled, so I assume it either uses w720 or w1080

drojf commented 3 years ago

Ah ok, voice-only doesn'tt need changes then.

However the Answer Arcs ADV-mode script would need the w540@2x flag too, as it expects 1080p resolution.

TellowKrinkle commented 3 years ago

Yep, just made that one https://github.com/07th-mod/umineko-answer/pull/82

drojf commented 3 years ago

uh...it's confusing but there are three script variants for the answer arcs - "voice-only", "full", and "ADV". (while the question arcs only has two variants)

"full" is 1080p without ADV mode (NVL mode) "ADV" is 1080p with ADV mode

the ADV script is on the adv_mode branch: https://github.com/07th-mod/umineko-answer/blob/adv_mode/0.utf

TellowKrinkle commented 3 years ago

Oh I'll cherry-pick the commit after I merge onto the main branch I guess

drojf commented 3 years ago

yes that's fine