07th-mod / umineko-question

94 stars 9 forks source link

[Experimental Script] Missing `voicedelay` / `voicewait` #172

Closed drojf closed 1 year ago

drojf commented 1 year ago

This should have a voicewait or voicedelay

advchar "27"
langjp:dwave_jp 0, bea_2e938:「そうだ。@:dwave_jp 0, bea_2e939:だから妾はこれより、/
langen:dwave_eng 0, bea_2e938:^"Exactly.^@:dwave_eng 0, bea_2e939:^  So from now on, ^/
se1 59
langjp:dwave_jp 0, bea_2e940:#ff0000真実を語る時、赤を使うことにする#ffffff。」\
;<真実を語る時、赤を使うことにする:点処理
sl
langen:dwave_eng 0, bea_2e940:#ff0000^when I speak the truth, I will use red^#ffffff^."^\

MEta_ld r,$BUT_OdorokiA2,80

So, earlier on I think I scanned the script to fix this issue automatically, but I think in cases where the japanese and english lines are interlaced, I've missed fixing those lines.

For example, the below has voicedelay inserted correctly, but this doesn't have the japanese and english lines interlaced

advchar "15"
langjp:dwave_jp 0, sha_2e233:「……さっきの、その、@:dwave_jp 0, sha_2e234:…………褒美の話って、/
langjp:voicedelay 2020:dwave_jp 0, sha_2e235:^^……何ですか。」@
langen:dwave_eng 0, sha_2e233:^"...What was that, umm, ^@:dwave_eng 0, sha_2e234:^...just now...^/
sl
langen:voicedelay 2020:dwave_eng 0, sha_2e235:^...about a reward?"^@

If you find any more cases like that, just let me know and I'll try to scan the script for similar instances


Another instance was reported, I'm much more sure now it's whenever it goes jp->eng->jp->eng, but they're actually part of the same continued paragraph, that it has this problem

langjp:dwave_jp 0, but_2e607:「………そしてここがもっと腑に落ちない。@:dwave_jp 0, but_2e608:……黄金伝説は実在するって言って、/
langen:dwave_eng 0, but_2e607:^"......And something else makes even less sense.^@:dwave_eng 0, but_2e608:^  ...If the Legend of the Gold is actually true,^/

langjp:dwave_jp 0, but_2e609:^~ib~^どうして黄金が積めるんだ^~ib~^。@:dwave_jp 0, but_2e610:……まるで犯人はもう、自分だけは黄金を見つけていて、@:dwave_jp 0, but_2e611:お前らも見つけてみろって言ってるみたいに見えるじゃないか。」\
;<戦人
;<どうして黄金が積めるんだ:点処理
sl
langen:dwave_eng 0, but_2e609:^~ib~ then how were they able to pile up all that gold~ib~?^@:dwave_eng 0, but_2e610:^  ...It's almost like the culprit's already found the gold...^@:dwave_eng 0, but_2e611:^and is telling us to try and find it too."^\

Another one

langjp:dwave_jp 0, but_2e713:朱志香は貴賓室の鍵を開ける時、/
langen:dwave_eng 0, but_2e713:^  When Jessica unlocked the VIP room, she borrowed the key from Kanon-kun,^/
langjp:dwave_jp 0, but_2e714:嘉音くんに鍵を借りたが、^~ib~^返さなかった^~ib~^!@:dwave_jp 0, but_2e715: だから嘉音くんはマスターキーを持っていないんだッ!!」\
;<返さなかった:点処理
sl
langen:dwave_eng 0, but_2e714:^ ~ib~but didn't give it back~ib~^^!^@:dwave_eng 0, but_2e715:^  So Kanon-kun doesn't have a master key on him!!"^\
drojf commented 1 year ago

I believe most of these issues are now fixed on the experimental script (the fix_clickwait_test_rebase branch) as of b53542c2153c8d783b3d9584778d98fd3d590920

I used these two scripts for most of the issues, but some may have been fixed manually or by find and replace etc.:

  1. Run https://github.com/07th-mod/umineko-question/blob/fix_clickwait_test_rebase/tools/fix-missing-voice-delay/fix-missing-voice-delay.py to find places where voicedelays should be inserted
  2. Run https://github.com/07th-mod/umineko-question/blob/fix_clickwait_test_rebase/tools/fix-missing-voice-delay/apply-voice-delay.py to actually insert the delays