drojf
commented
6 years ago This should be fixed after applying 1543d8c5a80bc25d8df1bb1e7daa5768c14bf4b8, 1b2fa16d2330fb35691571314fc16a2a7bbfb8db, and a19b17a751e378b9c1dafba1534d454fc94b3fb5 :
- To fix text delays only appearing once reaching a clickwait: Unvoiced lines with a delay now use '!d' (inline text delay) and have their delay divided by 2 to match the original game (I think somebody globally doubled all the voice delays in the script). This should restore it back to how it was in the Steam/MG/07th mod game.
- To fix voice delay lengths: Voiced lines have delays set from their voice file (ffprobe used to extract voice file lengths). Timing starts from when the voice starts playing, not when the delay is encountered (this was the old behavior).
- for voiced delays, the custom 'voicedelay' function is used instead of 'delay'
- A function called 'voicedelay' has been added to give correct behavior - if you're editing related code, be sure to understand that function first. Chiru still starts the delay from when the text has finished displaying, but since it seems to work fine I'll just leave it for now.
zeparu
the scene immediately following this line has the !s0 problem (text doesn't appear until line is finished)
She took it, ......and after hesitating, opened it...and read what was insideOn chiru, the bug only affected voice lines? but maybe that was just a coincidence and there was something else breaking the automatically displaying text lines.
Also, the delays haven't been adjusted? They seem too short most of the time.
Edit: somehow changing the 'delay [delaytime]' commands to '!d[delaytime]` makes it show up correctly (as per japanese mode):
Also, why are all the delay values multiplied by 2 as compared to the japanese lines? Will have to check the git logs to see if someone just doubled all t he delays in the entire script.
I think the following steps are required:
change all the
delay Xto!d. This fixes the strange 'delay before line is shown' bug. (Sometimes thedelay Xused to be!wwhich has slightly different behavior -!wis a forced wait which stops you from clicking through. But fixing that can be done later)divide the delay amount by 2. I think the 2x delay was added in this commit: 0625660 ("Fixing issue with delay lines part 2", 2016-07-18) . However, it was applied globally, even to lines which had no voices on them.
for lines with voices only, scale the delay by the amount necessary + 100ms buffer. Also, test that the delay seems the correct amount.