search

0804EshitaSharma / e-commerce-app

0 stars 1 forks source link

Added-top-nav-bar-for-E-commerce-app #5

Closed 0804EshitaSharma closed 1 year ago

0804EshitaSharma commented 1 year ago
Screenshot 2023-05-31 at 1 46 10 PM

Changed to

Screenshot 2023-06-04 at 12 38 13 PM
0804EshitaSharma commented 1 year ago

I saw that you used regular CSS, does that mean we aren't going to use something like tailwind?

Also, should we use a different colour scheme and layout than what amazon has right now? I feel like if we're just copying their whole design, the project will just turn into us replicating amazon and give no thought to design instead of trying something new.

Actually, I liked that scheme at first place :) Do you have Any suggestions/preferences ? I will make the change accordingly, And I will also give it a thought, if I can come up with sth. cool.

Regarding Tailwind css, I was thinking of changing css to tailwind css but found it a little time consuming as I am new to that. I am not sure whether Tailwind css is good option or we should use combination of CSS and Tailwind css . What I found at first place is that using Tailwind Css is looking for individual properties of CSS in the doc and concatenating them in one ClassName property, it's nothing new. So, I am not sure whether it is worth spending time on that. So I wanted to discuss that in today's meeting.

a-jassi commented 1 year ago

Looks good to me and I really like the new color! Just wondering, since I'm doing the task of "dashboard with a search bar with filters for all products", just wanted to make sure that is probably a different search bar but I should keep it in similar style, right?

I think the navbar search bar should probably be the one with filters, so I don't think you would need to create a new one.

0804EshitaSharma commented 1 year ago

I think the current navbar looks good! Just wondering if we will have placeholder buttons along the top to the left for the different categories or just add them in as we go?

I guess placeholder button is a good idea for showing filters, or we can add it along with search bar as well, we can discuss that.

0804EshitaSharma commented 1 year ago

I think the current navbar looks good! Just wondering if we will have placeholder buttons along the top to the left for the different categories or just add them in as we go?

I guess placeholder button is a good idea for showing filters, or we can add it along with search bar as well, we can discuss that.