A few changes for consideration:

09th / YABEE

Export models from the Blender to Panda3D game engine

MIT License

107 stars 39 forks source link

A few changes for consideration: #34

Closed ArsThaumaturgis closed 5 years ago

ArsThaumaturgis commented 5 years ago

Support for "collider" and "portal" tags.
Support for exporting of alpha-values in vertex-colours. -- This is achieved by (optional) use of an additional layer of vertex-colours in Blender, as Blender doesn't include an alpha-channel in its vertex colours.
Support for exporting additional layers of vertex-colours.
Support for exporting vertex-colours if no material is present, but "force export vertex colors" is checked.

rdb commented 5 years ago

Not all of these changes seem related to each other. You should probably create separate issues for each request that touches on a separate feature of YABEE. It would probably help if you provided additional information on each point or possibly even a blend file containing said feature and explained the expected result.

ArsThaumaturgis commented 5 years ago

Ah, all right. I'll have to figure out how to do that, since they're all in one file.

ArsThaumaturgis commented 5 years ago

Okay, I think that I have it separated into three new commits. I thus intend to close this pull request, and open a new one for each of those.

ArsThaumaturgis commented 5 years ago

It seems that GitHub doesn't allow one to create pull requests beyond the most recent commit, short of creating a separate fork for each desired commit--unless I'm not seeing a means of doing it. I've created issues for each commit, including links to the commits in question, I believe. Is that acceptable, or do you want me to create separate forks?

rdb commented 5 years ago

I don't know what ninth prefers, but the normal way to do this is to just create a separate branch for each change, and then create a PR for each branch.

ArsThaumaturgis commented 5 years ago

Hmm... Fair enough, I suppose.

It is a bit awkward, since some of the changes related to vertex-colours take place in the same chunk of code, but it shouldn't be too difficult to sort out.

[edit]

Okay, it's done--but in order to isolate the changes, I ended up creating two of the pull requests within my own fork. (There may be a better way to do this--I don't know.) I don't know whether those will likely be visible to others than myself, so let me link to them here:

https://github.com/ArsThaumaturgis/YABEE/pull/2 https://github.com/ArsThaumaturgis/YABEE/pull/1