search

0ADMods / millenniumad

Millennium A.D. is a mod for 0 A.D. covering the AD 500–1000 timeframe.
http://wildfiregames.com/forum/index.php?showforum=297
GNU General Public License v2.0
35 stars 18 forks source link

Delete some unnecessary files. #51

Closed Nescio0 closed 4 years ago

Nescio0 commented 4 years ago

template_unit_champion_infantry_axeman.xml is obsolete thanks to https://code.wildfiregames.com/rP23780 .DELETED is for disabling files from the public mod. player_defaults.json is unnecessary.

StanleySweet commented 4 years ago

Notice the deleted files were just renamed so while the use of DELETED is dubious they contain actual backup code.

Nescio0 commented 4 years ago

Everything is preserved in the .git history, there is no need to keep superfluous .DELETED files.

StanleySweet commented 4 years ago

Sure. but your comment above didn't suggest you actually looked into those files.

StanleySweet commented 4 years ago

Damn, closed i

Nescio0 commented 4 years ago

What do you mean exactly?

StanleySweet commented 4 years ago

.DELETED is for disabling files from the public mod.

Could have meant, heh found those useless files, and deleted them. Since typically DELETED files don't have content (they need at least a char to be packaged though) you could have overlooked it :)

Nescio0 commented 4 years ago

gui/pregame/backgrounds.DELETED is meaningful, it disables the backgrounds from the public mod, but that's not the case for mainmenu_milleniumad.js.DELETED and session_millenniumad.js.DELETED.

StanleySweet commented 4 years ago

Not my point, but doesn't matter anyway.