search

0ADMods / millenniumad

Millennium A.D. is a mod for 0 A.D. covering the AD 500–1000 timeframe.
http://wildfiregames.com/forum/index.php?showforum=297
GNU General Public License v2.0
35 stars 18 forks source link

Attempt to merge with official mod #71

Open stereotipo opened 2 years ago

stereotipo commented 2 years ago

Hey Asterix! If you're reading, I finally figured out how to make pull request on github! I spent the last week to clean-up names and extra-files and I think the project may be ready for a merge! I don't know if it's right, but I would suggest to have a backup copy of the original mod anyway, because I think it's best to preserve the work of those who made it before. But I hope this could be a further improvement overall! Let me know!

tomasmatys commented 2 years ago

@StanleySweet i need your eyes here too

7wells commented 1 year ago

@StanleySweet Hi Stan, is 1000 A.D. currently developed in GitHub? It has been a while ago that I was involved in the base game 0 A.D. (forum name "Ceres"), and recently I was very much delighted to see the new 0 A.D. release. 🙂 Our kids wanted to add the 1000 A.D. mod, which now plays nicely with the latest base game release and asked me many questions, e.g. why a certain civ shows the wrong art (of another civ) when starting the game. And that's why I looked here in GitHub, i.e. if it makes sense to report such things in GitHub (and potentially also contribute to squash some bugs), or whether this should rather happen in the forum. As I am more familiar with GitHab than with Phab, I could try to help here about 1000 A.D. (and I saw that a similar possibility now exists via the community mod of 0 A.D., if I understood it right). To sum it up: How can I contribute here to help with e.g. this PR? Thanks for your patience and my best wishes for you and all kind people involved. 👍

StanleySweet commented 1 year ago

Hey @7wells nice to be reading from you. Yes you can definitely report issues and make PRs here! That is the case for all the other mods on 0ADmods. :)

7wells commented 1 year ago

@StanleySweet Why is the 0 A.D. Community mod at GitLab, whereas the other 0 A.D. mods are here at GitHub? Is a transition taking place, or have I overseen something?

PS: I have forked the 0 A.D. Community mod at GitLab: https://gitlab.com/7wells/0ad-community-mod-a26

StanleySweet commented 1 year ago

Hey,

The community mod is officially maintained by Wildfire games Those mods are not.

Initially there was a plan to migrate to a self hosted gitlab so developping the mod on Gitlab seemed smart. However Blender is migrating from Phabricator to Gitea and I decided to jump on that bandwagon instead since Gitlab community has a lot of missing features.

Anyway you should stop hijacking those conversations issues and contact me directly, after my break of course (check out the forums.

Best regards

Stan

De : 7wells @.> Envoyé : lundi 24 octobre 2022 à 19:49 À : 0ADMods/millenniumad @.> Cc : Stanislas Dolcini @.>; Mention @.> Objet : Re: [0ADMods/millenniumad] Attempt to merge with official mod (PR #71)

@StanleySweethttps://github.com/StanleySweet Why is the Community mod at GitLabhttps://gitlab.com/0ad/0ad-community-mod-a26, whereas the other mods are here at GitHub? Is a transition taking place, or have I overseen something?

— Reply to this email directly, view it on GitHubhttps://github.com/0ADMods/millenniumad/pull/71#issuecomment-1289380255, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABUFJGWMUJBSIP5MUJT62GLWE3DZTANCNFSM5MVHRTSA. You are receiving this because you were mentioned.Message ID: @.***>

7wells commented 1 year ago

Sure, will do! My apologies for hijacking this issue. :blush: