0KG0BUD
commented
6 years ago Thanks Sang. I actually noticed after I submitted that I had missed a bracket which resulted in a lot of problems. I resubmitted now, but alas too late.
Open sangjunp4rk opened 6 years ago
0KG0BUD
commented
6 years ago Thanks Sang. I actually noticed after I submitted that I had missed a bracket which resulted in a lot of problems. I resubmitted now, but alas too late.
Summary Grade: Satisfactory
Good job with your code! I really liked the way you clearly organized your html code with whitespace and indentations. It makes your code really easy to navigate and read. Also, I really like the way you used classes and ids to group your sections together. As your code grows in size, this will help organize and manage your website. Excellent start to the Ready program!
I included a few notes in both the html and css files for you to think more critically about. You can find these comments in the issues tab of your github. The most important thing is to spend more time with mobile resizing. I know that it can be tedious, but you should try to add mobile resizing so you can control how your website looks even on different mobile screens. Some suggestions would be to decrease the size of the images when the screen size decreases or rearrange the layout of the text and images so you don’t have to scroll horizontally to read everything. You had a great start to media resizing but I think you might have overdone it and as a result media resizing rules are being overrode or conflicted.