search

0ME9A / password

Password is a free online tool that helps you create strong and random passwords for your accounts. You can customize your password options and copy the generated password to your clipboard with one click.
https://password.ome9a.com
MIT License
5 stars 4 forks source link

Disable the Clipboard Icon when there is no generated password for UX #18

Closed DavidKozdra closed 10 months ago

DavidKozdra commented 10 months ago

image

The clipboard should not be clickable and should not become green on click

add disabled attribute to the icon conditionally until the password var is set to some thing

0ME9A commented 10 months ago

Thanks for the feedback, @DavidKozdra ! 🙌

I'll address the clipboard icon behaviour by adding the disabled attribute conditionally until the password variable is set to something. This should prevent the icon from being clickable and avoid the green highlight on click.

If you're interested in contributing or have any specific suggestions on how to implement this, feel free to jump in! Your input is valuable, and contributions are always welcome.

I'll work on this, but if you'd like to take a stab at it or collaborate, please let me know. Looking forward to your thoughts!

Thanks again for your help!

DavidKozdra commented 10 months ago

I will work on it pushing now

DavidKozdra commented 10 months ago

I'll need permission but the code is just this <IconButton disabled={!history[0]?.password} onClick={handleCopy} title={${isCopy ? "Copied" : "Copy"}} sx={{ p: ".5", m: 0, minWidth: "0", borderRadius: 2, color: ${isCopy ? "green" : ""}, display: "flex", alignItems: "center", }}

        in the Password Generator component
0ME9A commented 10 months ago

Hi @DavidKozdra,

I appreciate your willingness to work on the clipboard icon issue. I've invited you to collaborate on the repository. Feel free to proceed with the changes, and if you have any questions or need assistance, don't hesitate to ask.

Looking forward to your contributions!

Best regards, @0ME9A