0ME9A / password

Password is a free online tool that helps you create strong and random passwords for your accounts. You can customize your password options and copy the generated password to your clipboard with one click.
https://password.ome9a.com
MIT License
5 stars 4 forks source link

Added generation logic to fix #29 #41

Closed DavidKozdra closed 11 months ago

DavidKozdra commented 11 months ago

as mentioned in #29 the passwords that are generated treat the check box requirements as options not as requirements.

fixed it so as long as the length is at least 4 it will always include at least one of the selected items

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
password ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 8:07pm
DavidKozdra commented 11 months ago

In secure random on the client side is probably not an issue but we could add crypto, might require a new issue and some dependency research

0ME9A commented 11 months ago

Subject: Issue with Unselecting Required Characters in Password Section

Hi @DavidKozdra,

I've conducted thorough testing on the preview and identified an unexpected behaviour in the password section when I unselect all the required characters. I've attached screenshots illustrating the current behaviour and how it should ideally behave:

Current Behavior: image

Expected Behavior: image

I'd like to point out that this discrepancy in behaviour needs attention to ensure the password section functions as intended. I would greatly appreciate your insights and help in resolving this matter.

0ME9A commented 11 months ago

Hey @DavidKozdra,

There is still some issue in generating a password and also when we switch to another tab from home and return to the home/password-generator tab all values reset to default. Here is a video preview of the steps I've taken.

https://github.com/0ME9A/password/assets/83957658/4a29aa78-ba4b-4aed-a7c2-d25a49377fe7

DavidKozdra commented 11 months ago

damn, sorry about that thought I was testing enough I will keep at it