search

0Nom4D / GuardianDock

GuardianDock is a mobile app developed with Flutter for IOS and Android that allows Destiny users to check their stats and news about the game.
0 stars 0 forks source link

Fixing BungieAccountData formatting from API #23

Closed 0Nom4D closed 11 months ago

0Nom4D commented 11 months ago

Variable bungieNetMembershipId in the BungieAccountData data class could be nullable as shown below:

      {
        "bungieGlobalDisplayName": "Aled",
        "bungieGlobalDisplayNameCode": 2824, // <= When formatting, API thinks that bungieNetMembershipId always exists, but here it doesn't
        "destinyMemberships": [
          {
            "iconPath": "/img/theme/destiny/icons/icon_stadia.png",
            "crossSaveOverride": 0,
            "applicableMembershipTypes": [
              5
            ],
            "isPublic": true,
            "membershipType": 5,
            "membershipId": "4611686018521659565",
            "displayName": "Aled#2754",
            "bungieGlobalDisplayName": "Aled",
            "bungieGlobalDisplayNameCode": 2824
          }
        ]
      },
      {
        "bungieGlobalDisplayName": "ALED",
        "bungieGlobalDisplayNameCode": 3064,
        "bungieNetMembershipId": "31142636", // <= Compared here
        "destinyMemberships": [
          {
            "iconPath": "/img/theme/bungienet/icons/steamLogo.png",
            "crossSaveOverride": 0,
            "applicableMembershipTypes": [
              3
            ],
            "isPublic": true,
            "membershipType": 3,
            "membershipId": "4611686018526693254",
            "displayName": "KREKKX",
            "bungieGlobalDisplayName": "ALED",
            "bungieGlobalDisplayNameCode": 3064
          }
        ]
      },

Thus, I just had to make bungieMembershipId nullable and not mandatory for the BungieAccountData class to be created. Same thing in the fromJson static function.