search

0beqz / realism-effects

SSGI, Motion Blur, TRAA - Effects to enhance your three.js scene's realism
https://realism-effects-obeqz.vercel.app/
MIT License
1.43k stars 67 forks source link

Emissive objects? #13

Closed braebo closed 1 year ago

braebo commented 1 year ago

Hey there! Thanks for releasing such an amazing project!!

Are emissive textures supposed to work? They seem to have no effect, even when creating some random messages to test it out.

I'm trying to get a video texture to reflect on the floor like in one of your old examples but nothing seems to pick up light from emissive textures.

I just want to make sure I'm not missing something!

0beqz commented 1 year ago

Hey! Emissive objects should be supported. So your material needs to have an emissiveMap set and it should work then. But I'll check soon what could be the issue and if the texture being animated may cause some problems.

braebo commented 1 year ago

Hmm ok thanks! I tried with non-animated textures, and with/without any combination of ambient/directional/environment lighting. I will try to create a minimal reproduction example and link it here!

Perhaps it could be something in one of my custom Shader Materials or custom EffectPasses, because my scene also has this warning firing off like crazy: [.WebGL-0x138051ace00] GL_INVALID_OPERATION: Active draw buffers with missing fragment shader outputs.

Seems to be something regarding MRT?

0beqz commented 1 year ago

Interesting, this should definitely not come up because when it comes up usually your G-buffers will be messed up and tracing won't work at all. It has something to do with MRT but I'm not sure what could be triggering it. Is your browser version older?