search

0beqz / realism-effects

SSGI, Motion Blur, TRAA - Effects to enhance your three.js scene's realism
https://realism-effects-obeqz.vercel.app/
MIT License
1.41k stars 63 forks source link

Support for mobile devices #22

Open MajorMeerkatThe3rd opened 1 year ago

MajorMeerkatThe3rd commented 1 year ago

First of all, amazing what you have been doing here! Thank you for all your work here.

I was wondering if there will also be support for this on mobile. I tested with the AO effects and there seem to be issues on my Android device. Do you know a workaround for this?

kitaedesigns commented 1 year ago

Doesn't seem to work on iOS Safari either.

0beqz commented 1 year ago

Thanks! Yes, mobile support is always a priority. There are always platform-specific issues when implementing features so I have to look into these bugs before releasing new versions. Which AO effect are you using? If you are using SSAO (N8AO) then you should use the one from the N8's repository: https://github.com/N8python/n8ao as it's going to be deprecated in this repo. But I'll also look into the issues with the AO effect before releasing.

MajorMeerkatThe3rd commented 1 year ago

Thanks for looking into this @0beqz!

I noticed this issue for both approaches. I think it might have something to do with how the depth is computed.

adamDeluxe commented 11 months ago

For some reason seems to work fine on an iphone 8 plus running ios 15.5 but not a 13 pro running 17.1

MajorMeerkatThe3rd commented 11 months ago

@0beqz The issue seems to be with devices that only support WebGL1. On some iOS devices with Chrome, there is still WebGL1 used. And of course there some of the shader code doesn't work as it expects GLSL3 functions to work.