fix meshes being visible false, fix noise banding on planes

DanielBelmes commented 7 months ago

Found that with these newest changes that meshes with depthWrite false were being set to visible: false as the GBufferpass wasn't returning their visible state after running.
Found that some changes to getViewPosition and getViewZ in the Denoiser was causing a large band of noise to take up ground planes.

Feel free to just use this as an indicator of these bugs. I don't know if you've managed to test with these issues. Furthermore The SSG/SSR effect isn't super compatible with other effects as it doesn't adhere to the combined effect pipeline system they have in place. The InputColor is completely ignored. I have done modifications locally as well that uses some of the input Color but it breaks the example. But works in all our scenes.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
realism-effects	✅ Ready (Inspect)	Visit Preview	Jan 30, 2024 11:32pm

0beqz commented 5 months ago

Hey, thanks a lot for the PR. I'll look into the changes later on. I also noticed issues with the banding on ground plane but couldn't really find the particular cause so this is well appreciated as it affects many scene setups.

0beqz / realism-effects

fix meshes being visible false, fix noise banding on planes #39