search

0beqz / realism-effects

SSGI, Motion Blur, TRAA - Effects to enhance your three.js scene's realism
https://realism-effects-obeqz.vercel.app/
MIT License
1.43k stars 67 forks source link

Build via Github Actions and publish up-to-date preview/production deployment builds to npm #40

Open jo-chemla opened 8 months ago

jo-chemla commented 8 months ago

Hi, First-of-all, thanks for this great library of effects! I'd like to try-out some recent realism-effects which are not yet available in the module version published to npm 1.1.2. I see you have deployments set-up for production/preview - which might just be hooks to vercel, and publish up-to-date demo pages after any commit.

Could you also push the updated realism-effects build to npm within the same vercel deployment task? Or set-up a Github Action to do so, eventually on versioned? Would be great to test new featues without building the lib ourselves.

0beqz commented 6 months ago

Hey, thanks - appreciate that! True, well right now I'm hesitant to releasing the new version on npm due to the cross-platform issued that take quite some time to track and fix. That's why there's no release on npm yet. But with the Actions, it would definitely be better like that. Once this version is stable I'll look into implementing that.

jo-chemla commented 6 months ago

Thanks, that's great news, and congrats on this super lib!